feat: Backwards compatibility #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlambson
commented
Mar 27, 2025
| @@ -98,13 +98,13 @@ class ErrorMsg(enum.StrEnum): | |||
| CORRUPT_MAP = _("Could not parse map file.") | |||
| MISSING_INI = _("Missing necessary INI sections.") | |||
|
|
|||
| def __init__(self, uploaded_file: UploadedFile | File): | |||
| def __init__(self, uploaded_file: UploadedFile | File, *, ini_section_check: bool = True): | |||
There was a problem hiding this comment.
Todo: remove this jank and make a separate way to easily spin up the ini handler
- Fix docker compose for launching tests via pycharm. - Make a constant for `RUN_ENVIRONMENT`.
- Red Alert backwards compatible upload - Stop using `ZipStorage`. Revisit it at a later time.
- Fix download endpoint for backwards compatible client
- Fix tests for filtering on `is_backwards_compatible` - Stop crashing when optional files are missing
alexlambson
force-pushed
the
alex/feat/more-validators
branch
from
e0c8bff to
37f9f90
Compare
|
Huge thank you to @penev92 for https://github.com/penev92/D2kMissionEditor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo before merge