Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get Forge versions for specific Minecraft version #5

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

GamerVII-NET
Copy link
Contributor

A new public method, GetForgeVersions, has been added to the ForgeInstaller.cs class. This method returns the available Forge versions for a specific Minecraft version, improving the process of version management and installation.

A new public method, `GetForgeVersions`, has been added to the `ForgeInstaller.cs` class. This method returns the available Forge versions for a specific Minecraft version, improving the process of version management and installation.
The ad display function `showAd()` in `ForgeInstaller.cs` has been commented out to disable showing of ads. In addition, a package reference for "CmlLib.Core" in `CmlLib.Core.Installer.Forge.csproj` was removed and a new project reference to "CmlLib.Core.csproj" was added. This change will ensure the use of the most recent and relevant references.
@AlphaBs
Copy link
Member

AlphaBs commented Jun 30, 2024

your PR has too many changes. remove all changes except GetForgeVersions method

@GamerVII-NET
Copy link
Contributor Author

Please, do Squash and merge. Thank you!

@AlphaBs AlphaBs merged commit 48e18b8 into CmlLib:main Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants