OCPBUGS-64765: add -a option to crictl ps #2112
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2112/1/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the detection of the etcd static pod prior to effective handover of etcd to Pacemaker.
Without this change, there is a race condition where pacemaker could detect the static pod as gone while it still was being deleted. In this situation, it would try to start the podman etcd container and fail due to an address/port conflict with the static pod.
The addition of "-a" makes it so that Pacemaker's start of the podman etcd container will only happen once the static pod is completely absent.
Without this change, assisted-service installations get stuck, as explained in: https://issues.redhat.com/browse/OCPBUGS-64765