Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Oct 23, 2025

  • Drop functions has_resource_configured and is_resource_running
  • Dev: utils: Rename utils.is_quorate to utils.cluster_with_quorum

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.40%. Comparing base (2b481a7) to head (a409023).
⚠️ Report is 44 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 55.68% <50.00%> (+0.49%) ⬆️
unit 52.43% <75.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/crash_test/config.py 100.00% <ø> (ø)
crmsh/crash_test/main.py 97.36% <ø> (-2.64%) ⬇️
crmsh/crash_test/utils.py 86.76% <100.00%> (-3.35%) ⬇️
crmsh/utils.py 67.45% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 force-pushed the 20251023_reuse_code branch 2 times, most recently from 56d7835 to a409023 Compare October 27, 2025 09:05
@liangxin1300 liangxin1300 marked this pull request as ready for review November 4, 2025 11:19
@liangxin1300 liangxin1300 marked this pull request as draft November 20, 2025 06:58
liangxin1300 and others added 4 commits December 11, 2025 22:44
Drop functions `has_resource_configured` and `is_resource_running`
Parse xml to get quorum status instead of parseing command text output
@liangxin1300 liangxin1300 marked this pull request as ready for review December 11, 2025 14:55
@liangxin1300 liangxin1300 requested review from nicholasyang2022 and removed request for nicholasyang2022 December 11, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants