[crmsh-4.6] Dev: Prevent actions when offline nodes are unreachable #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before performing operations that require all nodes to be online or at least SSH-reachable, such as: - Joining a node to the cluster - Removing a node from the cluster - Configure SBD - Setup SBD - Setup QDevice - Removing QDevice Check for any offline nodes that are also unreachable. If such nodes are found, the operation is blocked, and the user is prompted to either bring the nodes online or forcibly remove them from the cluster. This enhances cluster safety by ensuring potentially problematic nodes are handled explicitly before critical actions are taken.
liangxin1300
force-pushed
the
20250606_remove_dead_node_crmsh46
branch
2 times, most recently
from
90c409b to
cb12970
Compare
liangxin1300
force-pushed
the
20250606_remove_dead_node_crmsh46
branch
from
cb12970 to
9d6c10d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #1814