Dev: xmlutil: Improve for completer of pacemaker remote node

[liangxin1300]

Problem

• Some commands don't need to complete pacemaker remote node, like:

crm node standby
crm cluster remove

• While some commands need to include pacemaker remote node, like:

crm resource failcount
crm resource move

See #1727

• The way to get remote node's name

/cib/status/node_state[@remote_node="true"]/@uname

Might have problem:

>>> xmlutil.listnodes()
['rm', 'alp-2']
# if the pacemaker remote RA's name changed from `rm` to `rm_node`, then got two remote nodes
>>> xmlutil.listnodes()
['rm', 'rm_node', 'alp-2']

Instead, get pacemaker remote node from crm_mon -1 --output-as=xml looks more accurately

  <nodes>
    <node name="alp-2" id="2" online="true" standby="false" standby_onfail="false" maintenance="false" pending="false" unclean="false" health="green" feature_set="3.20.0" shutdown="false" expected_up="true" is_dc="true" resources_running="1" type="member"/>
    <node name="rm_node" id="rm_node" online="true" standby="false" standby_onfail="false" maintenance="false" pending="false" unclean="false" health="green" shutdown="false" expected_up="false" is_dc="false" resources_running="0" type="remote"/>
  </nodes>

Solution

• Drop xmlutil.listnodes function, use utils.list_cluster_nodes instead
• Rename xmlutil.CrmMonXmlParser.get_node_list to xmlutil.CrmMonXmlParser.get_node_list_with_attr
• Add a new function xmlutil.CrmMonXmlParser.get_node_list to get node list including pacemaker remote node; Thus add a new completer completers.nodes_with_remote

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.21%. Comparing base (bb49ed3) to head (7e376f0).

Files with missing lines	Patch %	Lines
crmsh/xmlutil.py	90.00%	1 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
integration	54.46% <85.00%> (-0.01%)	⬇️
unit	52.80% <75.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
crmsh/bootstrap.py	86.56% <100.00%> (ø)
crmsh/completers.py	58.69% <100.00%> (+1.87%)	⬆️
crmsh/ui_resource.py	72.62% <100.00%> (ø)
crmsh/xmlutil.py	70.00% <90.00%> (-0.45%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.