Kim staging #5
Open
Kim staging #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed man page created
Incomplete sentence before the second example completed The bad command with the mis-named agent has been removed: [root@nodea ~]# pcs alert recipient add smtp-alert [email protected] Error: alert 'smtp-alert' does not exist
INSTALLATION section added Formatting improved Typo fixed Examples descriptions improved modified: alert_smtp_filtered.5 Man page regenerated to incorporate changes from markdown source file new file: alert_syslog.5.md Markdown source file for alert_syslog.sh man page added new file: alert_syslog.5 The generated alert_syslog.sh man page
modified: agents/alert_smtp_filtered.sh modified: agents/alert_syslog.sh modified: docs/alert_smtp_filtered.5 modified: docs/alert_smtp_filtered.5.md modified: docs/alert_syslog.5 modified: docs/alert_syslog.5.md Removed reference to "attributes" alerts as they are not a thing. Per documentation, supported alerts are "node,fencing,resource" Re-generated the man pages to reflect the .md source updates
Removed "attribute" filter type, as valid alert kinds are fencing,node,resource per documentation. Slight formatting changes Added debug trace options, commented out by default, which redirect trace and stderr messages to /var/log/pacemaker-alert_smtp-debug.log ``` \# set -xv \# exec 2 > /var/log/pacemaker-alert_smtp-debug.log ``` modified: alert_syslog.sh Removed "attribute" filter type, as valid alert kinds are fencing,node,resource per documentation. Added debug trace options, commented out by default, which redirect trace and stderr messages to /var/log/pacemaker-alert_syslog-debug.log ``` \# set -xv \# exec 2 > /var/log/pacemaker-alert_smtp-debug.log ``` deleted: alert_smtp_filtered.sh Moved alert_smtp_filtered.sh to alert_smtp.sh deleted: alert_smtp_filtered_debug.sh deleted: alert_syslog_debug.sh Removed the wrapper script in favor of turning on tracing within the script, commented out by default.
…nough to write ansible.
Added help screen modified: ../docs/alert_smtp.5.md Changed reference to previous filename to reflect the enhanced agent replacing alert_smtp. modified: ../docs/alert_smtp.5 Re-rendered alert_smtp.5 to incorporate changes to markdown file.
modified: agents/alert_syslog.sh Completed help screens modified: docs/alert_syslog.5.md Improved some verbiage and formatting modified: docs/alert_syslog.5 Regenerated to incorporate changes in the markdown source file
Added trailing \ to partial command line in example
Minor verbiage improvement
modified: alert_syslog.5 Regenerated to included the latest minor verbiage tweaks.
…testing calling man from alert_smtp.sh. Will complete alert_smtp.sh tomorrow.
Moved documentation to man page, script when executed in interactive session now calls up the man page. modified: agents/alert_syslog.sh Moved documentation to man page, script when executed in interactive modified: docs/alert_smtp.5 modified: docs/alert_smtp.5.md Fixed various errors in the documentation, fixed errant references to alert_syslog (which was authored first, result of cp and not catching required updates)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think everything from the previous (now-closed) PR is addressed. Please don't hold back any feedback if further changes are required.