Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: aligned several properties and resources #47

Merged
merged 2 commits into from
Sep 18, 2024
Merged

feat!: aligned several properties and resources #47

merged 2 commits into from
Sep 18, 2024

Conversation

dkooll
Copy link
Contributor

@dkooll dkooll commented Sep 18, 2024

BREAKING CHANGE: * data structure has changed due to renaming of properties and removal of resources.

Description

This PR aligns several properties and removes the firewall, firewall policy, collection rule and ip group resources. They are moved to different modules.

Also the deployment test is simplified.

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

Related Issue(s)

Fixes #46

feat!: aligned several properties and resources
9bb7bb7 
BREAKING CHANGE: * data structure has changed due to renaming of properties and removal of resources.
@dkooll dkooll added the enhancement New feature or request label Sep 18, 2024
@dkooll dkooll self-assigned this Sep 18, 2024
@dkooll dkooll requested a review from a team as a code owner September 18, 2024 07:42
jasperpostcn
jasperpostcn approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jasperpostcn jasperpostcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dkooll dkooll merged commit f155777 into main Sep 18, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperpostcn jasperpostcn jasperpostcn approved these changes

Assignees

@dkooll dkooll

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

properties and resources needs more allignment
2 participants
@dkooll @jasperpostcn