Fix4307:Showing irrelavant warning whenever wrong details are shared. #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Suryansh5545 removed the unnecessary commits. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4311 +/- ##
==========================================
- Coverage 72.93% 69.29% -3.64%
==========================================
Files 83 20 -63
Lines 5368 3573 -1795
==========================================
- Hits 3915 2476 -1439
+ Misses 1453 1097 -356
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -272,8 +272,7 @@ | |||
| vm.FormError = response.data.affiliation[0]; | |||
| } else { | |||
| $rootScope.notify("error", "Some error have occured . Please try again !"); | |||
| } | |||
| $rootScope.notify("error", vm.FormError); | |||
| } $rootScope.notify("error", vm.FormError); | |||
There was a problem hiding this comment.
@Suryansh5545 fixed it 👍
Suryansh5545
suggested changes
Mar 22, 2024
@Suryansh5545 i fixed it , now. |
|
closes #4308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed it don't shows the warning triggered unnecessarily