Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended CLI for "scout update panel" #4908

Open
Jakob37 opened this issue Oct 3, 2024 · 2 comments
Open

Extended CLI for "scout update panel" #4908

Jakob37 opened this issue Oct 3, 2024 · 2 comments

Comments

@Jakob37
Copy link
Collaborator

Jakob37 commented Oct 3, 2024

Is your feature request related to a problem in the current program to new available techology or software? Please describe and add links/citations if appropriate.

When setting up new institutes and panels, we have sometimes ended up renaming both ID and display name for panels during the "set up" phase.

Right now, the Scout CLI does not support these actions, which means that the maintainer needs to interact directly with the mongo DB to achieve this. This can be more risky compared to using the CLI (indeed we have encountered (fixable) issues after working with the db this way).

Describe the solution you'd like

In the scout update panel interface, would it be possible / make sense to add options for updating the display name and potentially the ID?

Not sure if updating the ID would cause trouble, or if you rather should remove / recreate in that case. But I suspect the display name should be OK to mutate?

The current CLI options:

Usage: scout update panel [OPTIONS]

  Update a panel in the database

Options:
  -p, --panel TEXT              Specify what panel to update  [required]
  --version FLOAT               Specify the version of a panel. If no version
                                the latest panel is chosen.
  -d, --update-date TEXT        Update the date for a panel
  -a, --add-maintainer TEXT     Add a maintainter user_id for a panel
  -r, --revoke-maintainer TEXT  Revoke maintainter status for user_id for a
                                panel
  --update-version FLOAT        Change the version of a panel
  --help                        Show this message and exit.
@dnil
Copy link
Collaborator

dnil commented Oct 3, 2024

I guess for us this is scary stuff since we rely on the panel id for integration with orders, LIMS etc, but I also see your point about setup phase - that is the phase where we also have "removal" of panels and introduction of almost the same with some afterthought added... Let's look, and feel very free to check it out or PR, but the remove-export-and-recreate does exist, so probably a low prio QoL/wontfix for us today.

@Jakob37
Copy link
Collaborator Author

Jakob37 commented Oct 4, 2024

OK makes sense. The remove-export-recreate is indeed an option.

We'll see next time I encounter this situation. I might come back with a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants