Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open panel reports in new tabs #4893

Open
Jakob37 opened this issue Sep 27, 2024 · 4 comments
Open

Open panel reports in new tabs #4893

Jakob37 opened this issue Sep 27, 2024 · 4 comments

Comments

@Jakob37
Copy link
Collaborator

Jakob37 commented Sep 27, 2024

Describe the solution you'd like

Our geneticists found it hard to navigate to the overview report through panel -> overview report (you lose the case breadcrumb at the top for the case).

Would it be possible to put a link to the overview next to the report in the top left?

top_left

@northwestwitch
Copy link
Member

northwestwitch commented Sep 27, 2024

I see, but what happens when you have many panels selected for a case? We have cases with >25 panels, and if you add a link for each one of them in the case sidebar then you need a very long monitor :)
Moving this to Scout anyway, so we can have a discussion there!

@Jakob37
Copy link
Collaborator Author

Jakob37 commented Sep 27, 2024

I see, but what happens when you have many panels selected for a case? We have cases with >25 panels, and if you add a link for each one of them in the case sidebar then you need a very long monitor :) Moving this to Scout anyway, so we can have a discussion there!

Hmm, aha. We normally have a bunch of non-selected panels but just one panel selected. Maybe that comes down to differences in how Lund / Stockholm works again.

Would it be too messy to put a small icon to the right of the panel then?

top_left

I think it would also be OK to leave as is. I think this is more a "nice to have" user ergonomics, than something that would block them.

But maybe open the panel in a new tab instead of navigating away from the case page? So that they don't "get lost" and lose track of the case they were working with.

@northwestwitch
Copy link
Member

Mm I wouldn't add it there because of the following reasons:

  • It is a report, so it should go under the Reports expandable thinghy, I think
  • If you have a default gene panel with a long name, then there won't be space for the link, example:
image
  • Unlike the coverage report on case page (that is created based on all genes from all selected panels), the genes overview report feels more connected to the specific panel in question. I don't know, it has always been like this with the reports from chanjo(1) and I guess our clinicians are used to it..

Of couse we could open the panel in a new tab, it would make it easier to understand which case is which!

@Jakob37
Copy link
Collaborator Author

Jakob37 commented Sep 27, 2024

Mm I wouldn't add it there because of the following reasons:

OK! Yes, that makes sense. Let's drop that line of thought then.

Of couse we could open the panel in a new tab, it would make it easier to understand which case is which!

OK, nice! I think this would be totally good enough for the Lund geneticists. Let's stick with this then.

@dnil dnil changed the title Report overview link on case Open panel reports in new tabs Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants