Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to do cross join in temporary file if size exceeds limits #63432

Merged
merged 21 commits into from
May 14, 2024

Conversation

p1rattttt
Copy link
Contributor

@p1rattttt p1rattttt commented May 6, 2024

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added possibility to do cross join in temporary file if size exceeds limits

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label May 6, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-feature Pull request with new product feature label May 6, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented May 6, 2024

This is an automated comment for commit 937107f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@p1rattttt p1rattttt changed the title Added possibility to do cross join in temporary file if size exceeds limits [WIP] Added possibility to do cross join in temporary file if size exceeds limits May 6, 2024
Copy link

clickhouse-ci bot commented May 6, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'New Feature', 'Improvement'

@vdimir vdimir self-assigned this May 7, 2024
src/Core/Settings.h Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.h Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.h Outdated Show resolved Hide resolved
src/Interpreters/HashJoin.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.cpp Outdated Show resolved Hide resolved
@ClickHouse ClickHouse deleted a comment from clickhouse-ci bot May 7, 2024
src/Interpreters/HashJoin.cpp Show resolved Hide resolved
src/Interpreters/HashJoin.cpp Show resolved Hide resolved
@p1rattttt p1rattttt changed the title [WIP] Added possibility to do cross join in temporary file if size exceeds limits Added possibility to do cross join in temporary file if size exceeds limits May 11, 2024
@p1rattttt p1rattttt requested a review from vdimir May 11, 2024 12:07
src/Interpreters/HashJoin.cpp Outdated Show resolved Hide resolved
src/Interpreters/TemporaryDataOnDisk.cpp Show resolved Hide resolved
tests/queries/1_stateful/00183_cross_join_external.sql Outdated Show resolved Hide resolved
src/Interpreters/HashJoin.cpp Show resolved Hide resolved
@vdimir vdimir added this pull request to the merge queue May 14, 2024
@vdimir
Copy link
Member

vdimir commented May 14, 2024

CI failures (not related to changes):

Stateless tests (debug) [4/5] — fail: 1, passed: 1251, skipped: 19 Details

02124_insert_deduplication_token_multiple_blocks ?

Stateless tests (msan) [6/6] — fail: 1, passed: 1061, skipped: 7 Details

#47866

Stress test (tsan) — Possible deadlock on shutdown (see gdb.log) Details

Server is not terminated after six minutes, not sure if this error can be related:

2024.05.14 12:52:27.740617 [ 61096 ] {} <Error> system.session_log_sender.DistributedInsertQueue.default: Code: 252. DB::Exception: Received from kng4alm55c.us-east-2.aws.clickhouse-staging.com:9440. DB::Exception: Too many parts (3000 with average size of 3.90 MiB) in table 'default.session_log_15518124106323855721 (cb73f5c0-6d9f-4c47-b16a-93391fd753eb)'. Merges are processing significantly slower than inserts. Stack trace:

Merged via the queue into ClickHouse:master with commit 5338339 May 14, 2024
225 of 232 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 14, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request May 15, 2024
baibaichen added a commit to apache/incubator-gluten that referenced this pull request May 15, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515)

* Fix build due to ClickHouse/ClickHouse#63432

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants