Fix DocumenterCitations error #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
added
documentation
amylu00
approved these changes
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 41 41
Lines 1605 1605
=======================================
Hits 1538 1538
Misses 67 67
|
trontrytel
force-pushed
the
aj/docs_testing
branch
from
00dff73 to
482def9
Compare
goerz
reviewed
Nov 16, 2024
| @@ -397,7 +397,7 @@ @article{Koop2002 | |||
|
|
|||
| @article{Lehtinen2007, | |||
| title = {Estimating nucleation rates from apparent particle formation rates and vice versa: Revised formulation of the Kerminen–Kulmala equation}, | |||
| author = {Kari E.J. Lehtinen and Miikka {Dal Maso} and Markku Kulmala and Veli-Matti Kerminen}, | |||
| author = {Kari E.J. Lehtinen and Miikka Dal Maso and Markku Kulmala and Veli-Matti Kerminen}, | |||
There was a problem hiding this comment.
This is not correct: it changes the last name "Dal Maso" to "Maso" with "Dal" as a middle name. The correct way to handle this is to use the "Last, First" format.
@article{Lehtinen2007,
title = {Estimating nucleation rates from apparent particle formation rates and vice versa: Revised formulation of the Kerminen–Kulmala equation},
author = {Lehtinen, Kari E.J. and Dal Maso, Miikka and Kulmala, Markku and Kerminen, Veli-Matti},
journal = {Journal of Aerosol Science},
volume = {38},
number = {9},
pages = {988-994},
year = {2007},
doi = {10.1016/j.jaerosci.2007.06.009}
}
|
By the way, I don't think you're using the correct CSS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs stopped building with
DocumenterCitations v1.3.5. They were working fine with previous versions.Following the discussion in JuliaDocs/DocumenterCitations.jl#78 I removed the TeX commands in favor of unicode in authors names. The actual fix is removing
{from{Dal Maso}in line 400. I want to keep the other changes too, because they are more in line with the above mentioned discussion.