Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ClimaParameters 0.8 #288

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update to ClimaParameters 0.8 #288

merged 1 commit into from
Jan 18, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jan 18, 2024

Content

  • Removes src/parameters/Thermodynamics.jl and replaces the CM thermo params constructor with the new constructor from the Thermodynamics package.
  • Propagates above change to all tests and docs
  • Fixes broken create_toml_dict calls
  • DOES NOT change CloudMicrophysics parameter constructors, since the internals of the toml dict are unchanged except for alias removal. I will add a later PR that uses ClimaParameters properly, this PR only sets compatibility with the breaking changes.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63b15c8) 98.53% compared to head (4dfe3ff) 98.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.01%     
==========================================
  Files          32       31       -1     
  Lines         819      815       -4     
==========================================
- Hits          807      803       -4     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nefrathenrici nefrathenrici merged commit f38a6a4 into main Jan 18, 2024
10 checks passed
@nefrathenrici nefrathenrici linked an issue Jan 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the new CLIMAParameters
2 participants