This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Enable dims argument for weighted norms #590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 14, 2019
590: Enable dims argument for weighted norms r=simonbyrne a=simonbyrne Previously this threw an error Co-authored-by: Simon Byrne <[email protected]>
Build failed |
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=========================================
+ Coverage 68.02% 68.2% +0.18%
=========================================
Files 82 82
Lines 5620 5618 -2
=========================================
+ Hits 3823 3832 +9
+ Misses 1797 1786 -11
Continue to review full report at Codecov.
|
simonbyrne
force-pushed
the
sb/weighted-norm-dims
branch
from
1a8bd84 to
6f18f44
Compare
|
bors try |
tryBuild failed |
Previously this threw an error
simonbyrne
force-pushed
the
sb/weighted-norm-dims
branch
from
6f18f44 to
ed464b6
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 14, 2019
590: Enable dims argument for weighted norms r=simonbyrne a=simonbyrne Previously this threw an error Co-authored-by: Simon Byrne <[email protected]>
Build failed |
| @@ -488,7 +488,7 @@ function weighted_norm_impl(Q::SubArray{FT, N, A}, W, ::Val{p}, dims::Colon) whe | |||
| if isfinite(p) | |||
| accum += W[i, 1, k] * abs(Q[i, j, k]) ^ p | |||
| else | |||
| waQ_ijk = W[i, j, k] * abs(Q[i, j, k]) | |||
| waQ_ijk = W[i, 1, k] * abs(Q[i, j, k]) | |||
There was a problem hiding this comment.
Why is this being changed? (And why is the line above read with a 1 also: accum += W[i, 1, k] * abs(Q[i, j, k]) ^ p?)
There was a problem hiding this comment.
weights are set up to have size(weights, 2) == 1
blallen
added
the
DG Kernels
|
@simonbyrne, is this PR still relevant? |
|
yes, we still need to fix it. |
| @test norm(QAW, Inf) ≈ norm(globalA, Inf) | ||
|
|
||
| if ArrayType == Array | ||
| # TODO: make this work with CuArrays |
There was a problem hiding this comment.
NLsolve.jl needs the same thing
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this threw an error