Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resource_bundles for privacy manifest #324

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

maikelvdh
Copy link
Contributor

This is done to avoid getting build issues with multiple commands trying to produce xcprivacy file in application bundle.

For a more detailed explanation see: google/promises#226 (comment)

@maikelvdh maikelvdh changed the title fix: use resource_bundles for privacy manifest fix: use resource_bundle for privacy manifest Apr 11, 2024
@maikelvdh maikelvdh changed the title fix: use resource_bundle for privacy manifest fix: use resource_bundles for privacy manifest Apr 11, 2024
@akashvercetti akashvercetti changed the base branch from master to develop April 11, 2024 13:32
@akashvercetti akashvercetti self-requested a review April 11, 2024 13:33
@akashvercetti akashvercetti merged commit 16ff6b8 into CleverTap:develop Apr 12, 2024
2 checks passed
@harrynguyen22
Copy link

Hi guys I'm afraid this doesn't work. I just tried to install version 6.2.1 to our project and it still seems to collide with our main app's PrivacyInfo.xcprivacy. Here are the changes when installing, I notice there's PrivacyInfo.xcprivacy line added in our [CP] Copy Pod Resources.

image

Meanwhile with other SDKs, installing them doesn't that line, it'd be SDK.bundle or SDK_Privacy.bundle only
image

Could you guys help to take a look?

@akashvercetti
Copy link
Collaborator

@harrynguyen22 could you share more about the error via a screenshot? Maybe a sample app with just the CT SDK?

@harrynguyen22
Copy link

hi sorry false alarm, turns out it's due to another SDK which is SVProgressHUD, I'm checking the comments there. Thanks for the response tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants