Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclusion setting for domains ( related issue #353 ) #383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KMohZaid
Copy link

Problem in this PR is : I am "noob" and i don't know how to use i18n translation . so we have to do it.

@KMohZaid KMohZaid changed the title add exclusion setting for domains ( related issue -https://github.com/ClearURLs/Addon/issues/353 ) add exclusion setting for domains ( related issue #353 ) Sep 19, 2024
@KMohZaid
Copy link
Author

KMohZaid commented Sep 19, 2024

related issue : #353

(wow sonarcloud, i didnt know they have this intregation for free)

@KMohZaid
Copy link
Author

lol, i knew i should do something to keep 1 return url statement but lazy to do and it was feeling complex if i does

and sad, i forgot to remove test console.log

@KMohZaid
Copy link
Author

image
preview

@Beagle
Copy link

Beagle commented Sep 30, 2024

@KMohZaid +1 to have this merged in and released. I would love to finally have this feature in ClearURLs. It would make my life so much better.

@KMohZaid
Copy link
Author

KMohZaid commented Oct 4, 2024

Lol I didn't notice a mistake

In regex explanation, after m there was ? which i think i accidentally removed

(ClearURLs#383 (comment))

1. using variable to store boolean and if any boolean is true, then
   return url
2. using for-of for list
3. we are using "storage" variable to store dictionary data not array,
   so made it "{}" from "[]"
4. "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)
@KMohZaid
Copy link
Author

KMohZaid commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues 5 New issues 0 Accepted issues

Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

fix: 5 issues reported by sonarcloud
4e31424

(#383 (comment))

  1. using variable to store boolean and if any boolean is true, then
    return url
  2. using for-of for list
  3. we are using "storage" variable to store dictionary data not array,
    so made it "{}" from "[]"
  4. "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)

Copy link

sonarcloud bot commented Oct 9, 2024

@KMohZaid
Copy link
Author

KMohZaid commented Oct 9, 2024

@tcelestino
Copy link

This PR is a feature to solves the #387 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants