-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exclusion setting for domains ( related issue #353 ) #383
base: master
Are you sure you want to change the base?
Conversation
related issue : #353 (wow sonarcloud, i didnt know they have this intregation for free) |
lol, i knew i should do something to keep 1 return url statement but lazy to do and it was feeling complex if i does and sad, i forgot to remove test console.log |
@KMohZaid +1 to have this merged in and released. I would love to finally have this feature in ClearURLs. It would make my life so much better. |
Lol I didn't notice a mistake In regex explanation, after |
(ClearURLs#383 (comment)) 1. using variable to store boolean and if any boolean is true, then return url 2. using for-of for list 3. we are using "storage" variable to store dictionary data not array, so made it "{}" from "[]" 4. "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)
fix: 5 issues reported by sonarcloud
|
Quality Gate passedIssues Measures |
nice |
This PR is a feature to solves the #387 issue. |
Problem in this PR is : I am "noob" and i don't know how to use
i18n
translation . so we have to do it.