Add support for custom rules #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a textarea in the settings page that can be used to enter custom rules in the same format as data.json. These rules are applied on top of the ones from data.json.
start.getKeys() was using a for...in loop to iterate over fields in the given object, meaning that methods names (e.g. getOrDefault()) get included in the iteration as well. This causes erroneous entries to be added the global list of providers. Fix this by using Object.keys() to extract field names and iterate over that instead.
|
Kudos, SonarCloud Quality Gate passed!
|
|
That's exactly what I was looking for in the extension options, thinking this was a base feature. |
|
Good idea. It will also help to submit improved rules to the core set, as advanced users may test the rules easier. |
|
Please merge it :s |
|
@KevinRoebert this PR exists for more than two years now, could you please merge it or decline, so that we all know how things are with this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a textarea in the settings page that can be used to enter custom rules in the same format as data.json. These rules are applied on top of the ones from data.json.