Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom rules #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kgmt0
Copy link

@kgmt0 kgmt0 commented Aug 25, 2022

This adds a textarea in the settings page that can be used to enter custom rules in the same format as data.json. These rules are applied on top of the ones from data.json.

kgmt0 added 2 commits August 26, 2022 03:38
This adds a textarea in the settings page that can be used to enter
custom rules in the same format as data.json. These rules are applied on
top of the ones from data.json.
start.getKeys() was using a for...in loop to iterate over fields in the
given object, meaning that methods names (e.g. getOrDefault()) get
included in the iteration as well. This causes erroneous entries to be
added the global list of providers. Fix this by using Object.keys() to
extract field names and iterate over that instead.
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheCrazyMax
Copy link

That's exactly what I was looking for in the extension options, thinking this was a base feature.
Is there any plan to merge this ? :)

@inson1
Copy link

inson1 commented Dec 15, 2023

@KevinRoebert ?

@WolfganP
Copy link

Good idea. It will also help to submit improved rules to the core set, as advanced users may test the rules easier.

@Acelya-9028
Copy link

Please merge it :s

@mateuszjablonski
Copy link

@KevinRoebert this PR exists for more than two years now, could you please merge it or decline, so that we all know how things are with this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants