Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Av4 flow rate page #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Av4 flow rate page #8

wants to merge 2 commits into from

Conversation

underdoggum
Copy link
Collaborator

@underdoggum underdoggum commented Feb 12, 2025

Description

  • Create page for user-submitted ingress flow rate calculations
    • basically copying styles/organization from mother-concentration-solution page
  • Change text color for flow-rate and mother-concentration-solution to black (may need to change to white if black background preferred, judging by home page)
  • quick bug fix for when a user submits while inputs cleared out
  • quick bug fix for divide by 0 on flow-rate and mother-concentration-solution submit

How to Test

npm run dev

image

<div className="main-content">
<div className="header-wrapper">
<h1 className="page-header">
Reservoir Ingress Flow Rate Formula
Copy link
Collaborator Author

@underdoggum underdoggum Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear on the wording to use here:
"Reservoir Ingress Flow Rate" vs. just "Flow Rate" etc.

Also wasn't sure whether to re-label everything as Flow Rate instead of Reservoir Ingress, e.g. URL path, title of the page, wording in the description, and code variable references

Copy link
Collaborator Author

@underdoggum underdoggum Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on a translation to put description here
edit: NVM. Description will be added in #12

@underdoggum underdoggum marked this pull request as ready for review February 16, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant