Add attributes to isis interface resource (#219)

CiscoDevNet · Jun 6, 2024 · f14bc66 · f14bc66
1 parent e23b88f
commit f14bc66
Show file tree

Hide file tree

Showing 9 changed files with 65 additions and 0 deletions.
diff --git a/docs/data-sources/isis_interface.md b/docs/data-sources/isis_interface.md
@@ -44,6 +44,7 @@ data "nxos_isis_interface" "example" {
 - `authentication_type_l1` (String) IS-IS Authentication-Type for Level-1.
 - `authentication_type_l2` (String) IS-IS Authentication-Type for Level-2.
 - `circuit_type` (String) Circuit type.
+- `enable_ipv4` (Boolean) Enabling ISIS router tag on Interface's IPV4 family.
 - `hello_interval` (Number) Hello interval.
 - `hello_interval_l1` (Number) Hello interval Level-1.
 - `hello_interval_l2` (Number) Hello interval Level-2.
@@ -52,6 +53,7 @@ data "nxos_isis_interface" "example" {
 - `hello_multiplier_l2` (Number) Hello multiplier Level-2.
 - `hello_padding` (String) Hello padding.
 - `id` (String) The distinguished name of the object.
+- `instance_name` (String) Instance to which the interface belongs to.
 - `metric_l1` (Number) Interface metric Level-1.
 - `metric_l2` (Number) Interface metric Level-2.
 - `mtu_check` (Boolean) MTU Check for IS-IS without specific level.

diff --git a/docs/resources/isis_interface.md b/docs/resources/isis_interface.md
@@ -42,6 +42,7 @@ resource "nxos_isis_interface" "example" {
   hello_multiplier_l1     = 4
   hello_multiplier_l2     = 4
   hello_padding           = "never"
+  instance_name           = "ISIS1"
   metric_l1               = 1000
   metric_l2               = 1000
   mtu_check               = true
@@ -51,6 +52,7 @@ resource "nxos_isis_interface" "example" {
   passive                 = "l1"
   priority_l1             = 80
   priority_l2             = 80
+  enable_ipv4             = true
 }
 ```
 
@@ -85,6 +87,8 @@ resource "nxos_isis_interface" "example" {
   - Choices: `l1`, `l2`, `l12`
   - Default value: `l12`
 - `device` (String) A device name from the provider configuration.
+- `enable_ipv4` (Boolean) Enabling ISIS router tag on Interface's IPV4 family.
+  - Default value: `false`
 - `hello_interval` (Number) Hello interval.
   - Range: `1`-`65535`
   - Default value: `10`
@@ -106,6 +110,7 @@ resource "nxos_isis_interface" "example" {
 - `hello_padding` (String) Hello padding.
   - Choices: `always`, `transient`, `never`
   - Default value: `always`
+- `instance_name` (String) Instance to which the interface belongs to.
 - `metric_l1` (Number) Interface metric Level-1.
   - Range: `0`-`16777216`
   - Default value: `16777216`

diff --git a/examples/resources/nxos_isis_interface/resource.tf b/examples/resources/nxos_isis_interface/resource.tf
@@ -18,6 +18,7 @@ resource "nxos_isis_interface" "example" {
   hello_multiplier_l1     = 4
   hello_multiplier_l2     = 4
   hello_padding           = "never"
+  instance_name           = "ISIS1"
   metric_l1               = 1000
   metric_l2               = 1000
   mtu_check               = true
@@ -27,4 +28,5 @@ resource "nxos_isis_interface" "example" {
   passive                 = "l1"
   priority_l1             = 80
   priority_l2             = 80
+  enable_ipv4             = true
 }
diff --git a/gen/definitions/isis_interface.yaml b/gen/definitions/isis_interface.yaml
@@ -154,6 +154,12 @@ attributes:
       - never
     default_value: always
     example: never
+  - nxos_name: instance
+    tf_name: instance_name
+    type: String
+    description: 'Instance to which the interface belongs to.'
+    omit_empty_value: true
+    example: ISIS1
   - nxos_name: metricLvl1
     tf_name: metric_l1
     type: Int64
@@ -228,6 +234,12 @@ attributes:
     default_value: 64
     description: 'Circuit priority.'
     example: 80
+  - nxos_name: v4enable
+    tf_name: enable_ipv4
+    type: Bool
+    default_value: false
+    description: "Enabling ISIS router tag on Interface's IPV4 family."
+    example: true
 test_prerequisites:
   - dn: sys/fm/isis
     class_name: fmIsis

diff --git a/internal/provider/data_source_nxos_isis_interface.go b/internal/provider/data_source_nxos_isis_interface.go
diff --git a/internal/provider/data_source_nxos_isis_interface_test.go b/internal/provider/data_source_nxos_isis_interface_test.go
diff --git a/internal/provider/model_nxos_isis_interface.go b/internal/provider/model_nxos_isis_interface.go
diff --git a/internal/provider/resource_nxos_isis_interface.go b/internal/provider/resource_nxos_isis_interface.go
diff --git a/internal/provider/resource_nxos_isis_interface_test.go b/internal/provider/resource_nxos_isis_interface_test.go