Conversation
- Model: autogenerate argspec via _build_options_from_model; use NdFabricName; propagate name to management; drop unsupported gathered state (states now merged/replaced/deleted/overridden) - Orchestrator: add ConfigActionsMixin; query_all uses _request with category=fabricGroup filter - Module: rewrite main() on NDStateMachine + config_actions; remove gathered docs/examples/branch; drop category/management.type from docs+examples (single-literals excluded from argspec); fill RETURN - Unit test: rewrite query_all tests to rest_send + monkeypatched _request (14 pass) - Integration: remove gathered test; strip category/type from tasks+vars - Add changelog fragment Validated: ansible-test sanity 24/24 (core 2.18), units 14 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Resolves #527
Note
Stacked on top of #246 (branch
issue-245), which introduces the sharedmanage_fabric_groupbase package. Do not merge until #246 merges, thenthis branch will be rebased onto
develop.Proposed Changes
Adds a new
nd_manage_fabric_group_vxlan_acimodule to manage VXLAN-to-ACIFabric Groups (
management.type: vxlanAci) on Cisco Nexus Dashboard.Unlike the routed/AI-routed variants,
vxlanAciis not a clone of the baseVXLAN (MSD) fabric group — it exposes a smaller, distinct property set, so it is
implemented as a standalone model rather than a subclass.
plugins/module_utils/models/manage_fabric_group/manage_fabric_group_vxlan_aci.py)FabricGroupVxlanAciModel+VxlanAciFabricGroupManagementModel(single identifier
fabric_name,category: fabricGroup, discriminatormanagement.type: vxlanAci).securityGroupStatusis excluded from the argument spec and fromdiff comparison (via
to_diff_dictoverride).plugins/module_utils/models/manage_fabric_group/enums.py)FabricGroupTypeEnumwithVXLAN_ACI = "vxlanAci".VxlanAciOverlayInterConnectTypeEnum(manual,directPeering— norouteServer) andVxlanAciSecurityGroupTagEnum(loose,strict—no
off).plugins/module_utils/orchestrators/manage_fabric_group_vxlan_aci.py)ManageFabricGroupVxlanAciOrchestratorwires the sharedEpManageFabrics*endpoints; custom
query_allfilters on?category=fabricGroupandmanagement.type == "vxlanAci".plugins/modules/nd_manage_fabric_group_vxlan_aci.py)supports
merged,replaced,overridden,deletedand check mode.tests/unit/module_utils/endpoints/test_endpoints_api_v1_manage_fabric_group_vxlan_aci.py(18 tests — endpoint wiring,
query_allfiltering, argspec/model behavior).tests/integration/targets/nd_manage_fabric_group_vxlan_aci/(merged create/idempotent/update, replaced, deleted, multi-create).
changelogs/fragments/add_nd_manage_fabric_group_vxlan_aci.yml.Test Notes
18 passed(32 passed with the base VXLAN suite included).YAML validated with
yaml.safe_load.get_errorsclean across all new/changed source and test files.(
/api/v1/manage/fabrics) and require a reachable ND host in inventory.Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist