Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Closes #314
Proposed Changes
Adds two new ND fabric modules for Routed fabrics, built on the pydantic model +
state-machine architecture:
nd_manage_fabric_routed— standalone Routed fabric management (fabric typerouted)nd_manage_fabric_ai_routed— AI/ML Routed fabric management (fabric typeaimlRouted),subclassed from the routed base with AI QoS always enabled (frozen
aiml_qos)Per the OpenAPI spec (
docs/openapi/4.2.1/manage.json),routed/aimlRoutedsharebyte-for-byte identical property schemas with
vxlanEbgp/aimlVxlanEbgp— only thetypediscriminator differs — so the routed models mirror the eBGP VXLAN implementation.New/changed files:
plugins/module_utils/models/manage_fabric/manage_fabric_routed.py—RoutedManagementModel,FabricRoutedModelplugins/module_utils/models/manage_fabric/manage_fabric_ai_routed.py—AimlRoutedManagementModel,FabricAiRoutedModelplugins/module_utils/orchestrators/manage_fabric_routed.py—ManageRoutedFabricOrchestratorplugins/module_utils/orchestrators/manage_fabric_ai_routed.py—ManageAiRoutedFabricOrchestratorplugins/modules/nd_manage_fabric_routed.py,plugins/modules/nd_manage_fabric_ai_routed.pyplugins/module_utils/models/manage_fabric/enums.py— addedFabricTypeEnum.ROUTED/AIML_ROUTEDplugins/module_utils/models/manage_fabric/constants.py— wiredROUTEDinto pool/pattern/string mapstests/unit/module_utils/models/test_manage_fabric_routed.pytests/integration/targets/nd_manage_fabric/tasks/fabric_routed.yaml,fabric_ai_routed.yaml(+main.yaml/vars/main.yamlwiring)changelogs/fragments/add_nd_manage_fabric_routed.ymlTest Notes
python -m pytest tests/unit/module_utils/models/test_manage_fabric_routed.py→ 4 passed. Covers routed model type/identity, AI routed
aiml_qos=True,aiml_qosexclusion from argspec, and the locked/frozen
aiml_qosfield rejectingFalse.tests/integration/targets/nd_manage_fabric/coveringmerged(create/idempotent/update),replaced(create/idempotent),overridden, anddeleted(delete/idempotent), plus live API validation ofmanagement.type(
routed/aimlRouted) andaimlQos == truefor the AI variant.Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist