ND Interface Aggregator - #522
Draft
mikewiebe wants to merge 4 commits into
Draft
Conversation
mikewiebe
requested review from
akinross,
allenrobel,
anvitha-jain,
gmicol,
lhercot,
mtarking,
sajagana,
samiib and
shrsr
as code owners
August 25, 2026 03:14
mikewiebe
marked this pull request as draft
August 25, 2026 03:14
mikewiebe
marked this pull request as ready for review
August 25, 2026 14:56
mikewiebe
marked this pull request as draft
August 25, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Resolves #456
Proposed Changes
cisco.nd.nd_interfaces_workflow, a single aggregate workflow for the ten interface families currently available ondevelop.cisco.nd.nd_interface_flow_rulesoutside the aggregator scope.Why
manage_vpc_pair/resources.pychangesVpcPairStateMachinealready had a private_manage_override_deletions(override_exceptions)helper ondevelop. The sharedNDStateMachinealso had a same-named method. The interface-aggregator planning refactor changed the shared method to accept an optionalNDStatePlan, allowing a plan calculated before mutation to be reused during execution.That signature change exposed the pre-existing name collision as a pylint
arguments-renamedfailure: the shared method expects a state plan, while the vPC helper expects a list of pair identifiers that must be retained. The specialized vPC helper and its sole caller are therefore renamed to_manage_vpc_override_deletions(override_exceptions). This is a behavior-preserving compatibility change that avoids an incompatible override contract. A focused regression test verifies that override exceptions remain retained while other stale vPC pairs are deleted.Test Notes
12 passed.no-smart-quotesandpylintDocker sanity checks: passed.ansible-test sanity --docker --python 3.11 -v --color --truncate 0: all 32 sanity checks passed with exit status 0.git diff --check: passed.Cisco Nexus Dashboard Version
No Nexus Dashboard API behavior is changed by the vPC compatibility rename.
Related ND API Resource Category
Checklist
developwith merge conflicts resolved