Added fixes for output mismatch and returning status code got from ND - #455
Added fixes for output mismatch and returning status code got from ND#455jeetugangwar11 wants to merge 16 commits into
Conversation
jeetugangwar11
changed the title
allenrobel
left a comment
allenrobel
left a comment
There was a problem hiding this comment.
Code review
One finding, on the vPC-pair setup loop in rm_tasks.yaml. The RETURN_CODE/verbosity changes themselves look correct (status captured immediately after each request, no cross-request leakage; unit and integration assertions match the new behavior).
🤖 Generated with Claude Code
mtarking
changed the title
026da62 to
1b38301
Compare
allenrobel
left a comment
allenrobel
left a comment
There was a problem hiding this comment.
Re-review (post-approval changes)
Re-reviewed the changes pushed since the earlier approval. The only substantive post-approval change is the removed cleanup entry in base/delete.yaml (commit "[Jeet | issue-304] delete assertion fix"); the unit-test file changes are formatting-only. Two inline comments below — one on the removal itself, one on the related gathered/sanity count dedup it interacts with.
🤖 Generated with Claude Code
…D instead of harcoding 200 for successful operation.
This reverts commit 2bf47d4.
…C_DOMAIN_ID" as it will get create while vpc_pair
…. also updated README.md file
3b803a6 to
52ac3a2
Compare
|
@jeetugangwar11 conflicts need to be resolved |
4 participants
Issues:
Changes:
Use the HTTP RETURN_CODE provided by the ND response envelope for successful Resource Manager API operations instead of hardcoding 200.
Preserve the response metadata for resource create, update-delete, and delete operations.
Continue using a synthetic 200 response for check-mode and logical operations where no API request is sent.
Preserve per-resource operation status and messages in the response DATA.
Retain the actual ND response code for partial-success failures, such as HTTP 207 Multi-Status.
Test Notes:
Ran the complete Resource Manager unit test suite:
Verified that partial delete responses expose the ND-provided RETURN_CODE: 207.
Verified that API path, verb, payload, response, result, metadata, and diff are returned correctly at -vvv.
Nexus Dashboard: 4.3.1.135.51166
Related ND API Resource Category:
manage
Checklist
Latest commit is rebased from develop with merge conflicts resolved
New or updates to documentation has been made accordingly
Assigned the proper reviewers