Fixes clamdscan "Unable to determine the filepath given the file descriptor"#1655
Open
finchy wants to merge 1 commit intoCisco-Talos:mainfrom
Open
Fixes clamdscan "Unable to determine the filepath given the file descriptor"#1655finchy wants to merge 1 commit intoCisco-Talos:mainfrom
finchy wants to merge 1 commit intoCisco-Talos:mainfrom
Conversation
…riptor" Fixes Cisco-Talos#1653 Updated the CheckFDPassing.cmake file to ensure proper support for file descriptor passing on OpenBSD by conditionally defining _XOPEN_SOURCE. The logic now attempts to compile without this definition first, and if that fails, retries with it. Additionally, included fdpassing.h at the beginning of clamdcom.c to ensure correct macro definitions.
e3417bb to
56d4042
Compare
|
This is a solid portability fix. i especially like that the CMake logic first attempts compilation without one question: did you verify whether redefining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653
Updated the CheckFDPassing.cmake file to ensure proper support for file descriptor passing on OpenBSD by conditionally defining _XOPEN_SOURCE. The logic now attempts to compile without this definition first, and if that fails, retries with it. Additionally, included fdpassing.h at the beginning of clamdcom.c to ensure correct macro definitions.