clamd: fix MaxQueue off-by-one in acceptloop#1618
Open
MegaManSec wants to merge 1 commit intoCisco-Talos:mainfrom
Open
clamd: fix MaxQueue off-by-one in acceptloop#1618MegaManSec wants to merge 1 commit intoCisco-Talos:mainfrom
MegaManSec wants to merge 1 commit intoCisco-Talos:mainfrom
Conversation
Block when recv_fds->nfds >= MaxQueue and only signal when queue < limit, preventing a +1 over-accept. This bug was found with ZeroPath. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
Contributor
|
Thank you for the PR. I reviewed this early this week and must have not submitted my comment. I believe your change is technically correct but does not fix any behavioral issue or technical problem. As far as I could tell from reading the code, the MaxQueue limit is not used for any allocation and so the only consequence of going higher than the queue limit is more thing in the queue. The default queue limit is 200. If my understanding is correct, the existing version actually allows for 201 items in he queue and your fix makes it actually limit to 200. Is that right? |
Author
|
Yes, it's just a tiny correctional but, nothing serious at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block when recv_fds->nfds >= MaxQueue and only signal when queue < limit, preventing a +1 over-accept.
This bug was found with ZeroPath.