Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize bindgen #1136

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Conversation

shutton
Copy link
Contributor

@shutton shutton commented Jan 9, 2024

Centralize all use of bindgen (which exposes libclamav symbols to Rust code) into the clamav-sys module. libclamav_rust is no longer responsible for exporting internal symbols, and is focused only on exporting C-compatible symbols referencing code implemented in Rust.

zaddach and others added 26 commits November 20, 2020 09:12
* Switch to "newtype" enums
* Exposed:
    - cl_set_clcb_msg()
    - cl_cvdparse() and supporting symbols
    - cl_debug()
    - DB load/progress callback setting functions
    - engine scan callbacks and types
    - File file inspection callbacks and types
* Moved allowlisted funcs/types/variables to constants
* Updated bindgen dependency
…y-and-authors

Update repository, authors, and copyright.
Merge the clamav-sys Rust crate into clamav, preserving history
@shutton shutton self-assigned this Jan 9, 2024
@shutton shutton marked this pull request as draft January 9, 2024 18:09
@shutton shutton force-pushed the centralize-bindgen branch 4 times, most recently from f12c76d to 376a21d Compare January 9, 2024 22:04
@shutton shutton force-pushed the centralize-bindgen branch 3 times, most recently from 26b79f0 to dba749a Compare January 12, 2024 19:51
micahsnyder and others added 3 commits January 19, 2024 10:49
Some builds using the tarball with the vendored Rust dependencies are
failing.

The onenote-rs dependency is presently tied to a git branch from github
rather than using a release from crates.io. This is the differing factor
though I'm unsure why it is causing the build to try to update the repo
rather than just building the vendored source.

This commit adds a `--offline` parameter to the build options if the
vendored source is detected, in an attempt to force Cargo to use what it
has and stay offline.
Export additional build context to Rust-based builds, and eliminate some of the
duplicated logic when bulding a macOS univeral binary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants