Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clam 2386 clang 16 upgrade clam bc lowering #32

Conversation

ragusaa
Copy link
Contributor

@ragusaa ragusaa commented Aug 31, 2023

No description provided.

@ragusaa ragusaa changed the base branch from main to Clang-16-Upgrade August 31, 2023 19:42
@ragusaa ragusaa force-pushed the CLAM-2386-Clang-16-Upgrade-ClamBCLowering branch from 23566ac to 27a9e53 Compare August 31, 2023 19:43
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the copyright thing, which will apply to all the passes, I don't see any issues. We can always deal with the copyright update later all at once.

/*
* Compile LLVM bytecode to ClamAV bytecode.
*
* Copyright (C) 2009-2010 Sourcefire, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only just realized this, but all of these copyright statements throughout should be updated to be like:

 *  Copyright (C) 2013-2023 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
 *  Copyright (C) 2009-2013 Sourcefire, Inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that, thanks

@ragusaa ragusaa merged commit 035e176 into Cisco-Talos:Clang-16-Upgrade Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants