Added a button to navigate back to the main CV website(Solves #229) #236
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| <header class="fixed-top navigation"> | ||
| <div class="container"> | ||
| <!-- navbar --> | ||
| <nav class="navbar px-0 navbar-expand-lg navbar-light bg-transparent"> | ||
| <a class="navbar-brand" href="{{ .Site.BaseURL }}"> | ||
| <img | ||
| class="img-fluid" | ||
| src="{{ .Site.Params.logo | relURL }}" | ||
| alt="{{ .Site.Title }}" | ||
| /> | ||
| </a> | ||
| <button | ||
| class="navbar-toggler border-0 px-0" | ||
| type="button" | ||
| data-toggle="collapse" | ||
| data-target="#navigation" | ||
| > | ||
| <i class="ti-menu text-dark h3"></i> | ||
| </button> | ||
|
|
||
| <div class="collapse navbar-collapse text-center" id="navigation"> | ||
| <ul class="navbar-nav ml-auto"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link" href="{{ .Site.BaseURL }}" | ||
| >{{ with .Site.Params.Home }} {{ . }} {{ end }}</a | ||
| > | ||
| </li> | ||
| {{ range .Site.Menus.main }} {{ if .HasChildren }} | ||
| <li class="nav-item dropdown"> | ||
| <a | ||
| class="nav-link dropdown-toggle" | ||
| href="#" | ||
| role="button" | ||
| data-toggle="dropdown" | ||
| aria-haspopup="true" | ||
| aria-expanded="false" | ||
| > | ||
| {{ .Name }} | ||
| </a> | ||
| <div class="dropdown-menu"> | ||
| {{ range .Children }} | ||
| <a class="dropdown-item" href="{{ .URL | absURL }}" | ||
| >{{ .Name }}</a | ||
| > | ||
| {{ end }} | ||
| </div> | ||
| </li> | ||
| {{ else }} | ||
| <li class="nav-item"> | ||
| <a class="nav-link" href="{{ .URL | absURL }}">{{ .Name }}</a> | ||
| </li> | ||
| {{ end }} {{ end }} | ||
|
|
||
| <!-- CircuitVerse Button --> | ||
| <li class="nav-item"> | ||
| <a href="https://circuitverse.org" class="nav-link" target="_blank" rel="noopener"> | ||
| Go to CircuitVerse | ||
|
There was a problem hiding this comment. This text is a bit odd. Could think of a better link ? There was a problem hiding this comment. Pardon me if I am interpreting it wrong but are u referring to the" Go to CircuitVerse" text, if thats the case....sure we can modify it...I have thought of some alternatives like...CircuitVerse ,Simulator, Main Website.... There was a problem hiding this comment. P.S I have updated the comment to add before and after screenshots. |
||
| </a> | ||
| </li> | ||
| </ul> | ||
| {{ if .Site.Params.search.enable }} {{ "<!-- search -->" | safeHTML }} | ||
| <div class="search"> | ||
| <button id="searchOpen" class="search-btn"> | ||
|
There was a problem hiding this comment. Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control. |
||
| <i class="ti-search"></i> | ||
| </button> | ||
| <div class="search-wrapper"> | ||
| <form action="{{ `search` | absURL }}" class="h-100"> | ||
| <input | ||
| class="search-box px-4" | ||
| id="search-query" | ||
| name="s" | ||
| type="search" | ||
| placeholder="Type & Hit Enter..." | ||
| /> | ||
| </form> | ||
| <button id="searchClose" class="search-close"> | ||
|
There was a problem hiding this comment. Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control. |
||
| <i class="ti-close text-dark"></i> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| {{ end }} | ||
| </div> | ||
| </nav> | ||
| </div> | ||
| </header> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.