Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adding support for pnpm #199

Merged
merged 22 commits into from
Aug 21, 2024

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Dec 6, 2023

SEMVER Update Type:

  • Major
  • Minor
  • Patch

I would assume it is just a patch or minor as it doesn't change any of defaults or the normal behaviours, just adds an optional extra feature of pnpm as a package manager.

Description:

  • add support for pnpm as a package manager
  • fix test-deploy.yml node/test and node/run steps to find the correct lock files for the corresponding pkg-manager by removing the other ones

Motivation:

Closes Issues:

Also shows how someone could do this:

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@ramykl
Copy link
Contributor Author

ramykl commented Dec 7, 2023

Not sure what I need to do to get the circleCI checks to run here or if it requires a review to trigger them.
I'm not sure the uninstall steps are correct for pnpm as I just took the yarn steps. I didn't see a test for those. Possibly should just be simplified to assume pnpm was installed via npm install -g pnpm.

It would be great to have a bit more documentation about contributing and how to get all the checks to run.

@ramykl ramykl changed the title adding support for pnpm Feat: adding support for pnpm Dec 16, 2023
@ramykl
Copy link
Contributor Author

ramykl commented Dec 27, 2023

@KyleTryon Any help on getting these final tests to run here (btw they pass on my circleCI PR to my master branch)? Or what else I can do to get this PR to be processed?

@ramykl ramykl force-pushed the adding-pnpm-support branch from f4d907c to 9036d31 Compare December 27, 2023 21:09
@ramykl ramykl force-pushed the adding-pnpm-support branch from 67436ba to 8a85a24 Compare December 28, 2023 13:17
@ramykl ramykl force-pushed the adding-pnpm-support branch from b1dfe80 to 935a545 Compare December 28, 2023 13:36
@ramykl ramykl force-pushed the adding-pnpm-support branch from 4fb78a5 to 0119b40 Compare December 28, 2023 13:53
@ramykl
Copy link
Contributor Author

ramykl commented Jan 2, 2024

Here it is against main on my fork with the checks successful and complete ramykl#1

@w3bdesign w3bdesign mentioned this pull request Jan 9, 2024
@jennifer-shehane
Copy link

@KyleTryon Any chance to get a review on this? This would help with support on the cypress orb as well. cypress-io/circleci-orb#445

@KyleTryon
Copy link
Contributor

Hello all 👋 I just got back from vacation and ran your tests, all looks good! We're going to add this shortly, we just want to try to merge in some fixes before adding this feature. I'll update here shortly. Thanks again!

@ramykl
Copy link
Contributor Author

ramykl commented Feb 14, 2024

Any updates here? @KyleTryon

@KyleTryon
Copy link
Contributor

Any updates here? @KyleTryon

Sorry, I am no longer a member of CircleCI.

@ramykl
Copy link
Contributor Author

ramykl commented Feb 20, 2024

Sorry, I am no longer a member of CircleCI.

Sorry to hear that.

@ramykl
Copy link
Contributor Author

ramykl commented Feb 20, 2024

@brentmmarks Any chance of a review/update?

@ramykl
Copy link
Contributor Author

ramykl commented Mar 4, 2024

@EricRibeiro any chance of a review/update? Would be great to get this merged

@EricRibeiro
Copy link
Contributor

@EricRibeiro any chance of a review/update? Would be great to get this merged

I'm sorry, but I'm no longer working at CircleCI. It would be best to reach out to their support team for assistance with this pull request.

@ramykl
Copy link
Contributor Author

ramykl commented Mar 8, 2024

@brentmmarks Any chance of a review and merge please?

@ashfaqnisar
Copy link

@FelicianoTech any chance you could review this ?

@CodeBooster97
Copy link

Any news?

@ramykl
Copy link
Contributor Author

ramykl commented May 24, 2024

@ashfaqnisar or @FelicianoTech any news?

@AlvesJorge
Copy link

very thankful for your resilience @ramykl
Also it's somewhat funny that the only employees from circleci to respond are the ones that are no longer employees.

Bump

@MikeMcC399 MikeMcC399 mentioned this pull request Jul 23, 2024
@ramykl
Copy link
Contributor Author

ramykl commented Aug 20, 2024

@marboledacci any chance of a review?

@marboledacci
Copy link
Contributor

Hello @ramykl, after merging master into this, and running the tests, the PNPM tests are failing with:
 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json
If you can update this lock to make it work, I can merge it.

@ramykl
Copy link
Contributor Author

ramykl commented Aug 21, 2024

Thanks @marboledacci. I have updated it now. Also, I updated the test to get the latest version of pnpm.

@marboledacci marboledacci merged commit cc31fc8 into CircleCI-Public:master Aug 21, 2024
2 checks passed
@ramykl ramykl deleted the adding-pnpm-support branch August 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants