-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adding support for pnpm #199
Feat: adding support for pnpm #199
Conversation
e70e76d
to
c884ffb
Compare
Not sure what I need to do to get the circleCI checks to run here or if it requires a review to trigger them. It would be great to have a bit more documentation about contributing and how to get all the checks to run. |
@KyleTryon Any help on getting these final tests to run here (btw they pass on my circleCI PR to my master branch)? Or what else I can do to get this PR to be processed? |
f4d907c
to
9036d31
Compare
67436ba
to
8a85a24
Compare
b1dfe80
to
935a545
Compare
4fb78a5
to
0119b40
Compare
Here it is against main on my fork with the checks successful and complete ramykl#1 |
@KyleTryon Any chance to get a review on this? This would help with support on the cypress orb as well. cypress-io/circleci-orb#445 |
Hello all 👋 I just got back from vacation and ran your tests, all looks good! We're going to add this shortly, we just want to try to merge in some fixes before adding this feature. I'll update here shortly. Thanks again! |
Any updates here? @KyleTryon |
Sorry, I am no longer a member of CircleCI. |
Sorry to hear that. |
@brentmmarks Any chance of a review/update? |
@EricRibeiro any chance of a review/update? Would be great to get this merged |
I'm sorry, but I'm no longer working at CircleCI. It would be best to reach out to their support team for assistance with this pull request. |
@brentmmarks Any chance of a review and merge please? |
@FelicianoTech any chance you could review this ? |
Any news? |
@ashfaqnisar or @FelicianoTech any news? |
very thankful for your resilience @ramykl Bump |
@marboledacci any chance of a review? |
Hello @ramykl, after merging master into this, and running the tests, the PNPM tests are failing with: |
Thanks @marboledacci. I have updated it now. Also, I updated the test to get the latest version of pnpm. |
SEMVER Update Type:
I would assume it is just a patch or minor as it doesn't change any of defaults or the normal behaviours, just adds an optional extra feature of pnpm as a package manager.
Description:
pnpm
as a package managertest-deploy.yml
node/test
andnode/run
steps to find the correct lock files for the correspondingpkg-manager
by removing the other onesMotivation:
Closes Issues:
Also shows how someone could do this:
Checklist: