Fix issues with args (#199)

* Readd buildkit variable and test

* Test with buildkit false

* Use = for secret argument

* Update interpreter

* Add extra dockerfile with secret mounting

* Update docker image to debug

* Remove interpreter custom

* Remove env

* Update dockerfile

* Use a different executor

* Update executor

* Use another executor

* Use another executor

* Use another executor

* Update default version for docker executor

* Rever useless change

.circleci/test-deploy.yml

@@ -24,6 +24,7 @@ promotion_requires: &promotion_requires
     publish-docker-multiple-tags,
     publish-docker-env-var-image-param,
     test-pull,
+    integration-test-secret-args,
     test-install-docker-tools-docker-latest,
     test-install-docker-tools-docker-old,
     test-install-docker-tools-macos-latest,
@@ -232,6 +233,18 @@ jobs:
           image: ccitest/docker-orb-test
           tag: $CIRCLE_BUILD_NUM-$CIRCLE_SHA1
           extra_build_args: --build-arg COMMIT_HASH=$CIRCLE_SHA1
+  integration-test-secret-args:
+    executor: docker/docker
+    steps:
+      - checkout
+      - setup_remote_docker
+      - run: echo 'export COMPOSER_AUTH=SECRET_VALUE' >> $BASH_ENV
+      - docker/build:
+          dockerfile: test5.Dockerfile
+          image: ccitest/docker-orb-test-secret
+          tag: $CIRCLE_BUILD_NUM-$CIRCLE_SHA1
+          # use-buildkit: true
+          extra_build_args: "--secret id=COMPOSER_AUTH,env=COMPOSER_AUTH --progress=plain --no-cache"
   test-build-bash-substitution:
     docker:
       - image: cimg/base:current
@@ -317,6 +330,7 @@ workflows:
   test-deploy:
     jobs:
       - build-multispace-args
+      - integration-test-secret-args
       - docker/hadolint:
           name: hadolint
           ignore-rules: DL4005,DL3008,DL3009,DL3015,DL3059
@@ -509,7 +523,7 @@ workflows:
           name: publish-docker-save-cache
           executor: machine-latest
           context: cimg-docker-image-building
-          dockerfile: test4.Dockerfile
+          dockerfile: test2.Dockerfile
           image: ccitest/docker-orb-test
           tag: $CIRCLE_SHA1
           cache_to: ccitest/docker-orb-test:cache-big,ccitest/docker-orb-test:cache2-big
@@ -528,7 +542,7 @@ workflows:
             - publish-docker-save-cache
           executor: machine-latest
           context: cimg-docker-image-building
-          dockerfile: test4.Dockerfile
+          dockerfile: test2.Dockerfile
           image: ccitest/docker-orb-test
           tag: $CIRCLE_SHA1
           cache_from: ccitest/docker-orb-test:cache-big

src/commands/build.yml

@@ -117,6 +117,10 @@ steps:
             treat-warnings-as-errors: <<parameters.treat-warnings-as-errors>>
             dockerfile: <<parameters.path>>/<<parameters.dockerfile>>
             debug: <<parameters.debug>>
+  - when:
+      condition: <<parameters.use-buildkit>>
+      steps:
+        - run: echo 'export DOCKER_BUILDKIT=1' >> $BASH_ENV
 
   - when:
       condition: <<parameters.attach-at>>

src/executors/docker.yml

@@ -9,7 +9,7 @@ parameters:
 
   tag:
     type: string
-    default: "3.6"
+    default: "3.8"
     description: Image tag
 
 docker:

test5.Dockerfile

@@ -0,0 +1,6 @@
+#syntax=docker/dockerfile:1
+FROM composer:latest
+
+WORKDIR /var/www/html
+
+RUN --mount=type=secret,id=COMPOSER_AUTH,env=COMPOSER_AUTH,required echo $COMPOSER_AUTH