feat: report errors from LSP methods to rollbar #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvincent42
approved these changes
Oct 13, 2023
jvincent42
reviewed
Oct 13, 2023
jvincent42
approved these changes
Oct 13, 2023
loderunner
force-pushed
the
rollbar-log-json-rpc-errors
branch
from
ce0d833 to
04a8a9b
Compare
jvincent42
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will report errors from LSP methods to rollbar.
Implementation details
Implemented using a "middleware" style. It takes the "replier" function provided by the JSON RPC server, and wraps in a same-signature function, checking for an error, before reporting it to rollbar and passing it on to the original replier.