Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build service #16

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Use build service #16

merged 1 commit into from
Jul 9, 2018

Conversation

marcomorain
Copy link
Contributor

No description provided.

@marcomorain marcomorain force-pushed the use-build-service branch 3 times, most recently from 891448a to deb03e4 Compare July 9, 2018 13:02
@codecov-io
Copy link

codecov-io commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #16   +/-   ##
======================================
  Coverage    43.4%   43.4%           
======================================
  Files          10      10           
  Lines         622     622           
======================================
  Hits          270     270           
  Misses        330     330           
  Partials       22      22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22af4f8...e3f2c04. Read the comment docs.

@marcomorain marcomorain force-pushed the use-build-service branch 7 times, most recently from 3a3b8eb to 1c19c49 Compare July 9, 2018 13:45
zzak
zzak approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@zzak zzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcomorain It looks like you committed the pre-compiled config which loses indentation on the maps. Not a big deal tho, this PR LGTM when viewed with ?w=1.

@marcomorain marcomorain merged commit 7bd736d into master Jul 9, 2018
@marcomorain marcomorain deleted the use-build-service branch July 9, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzak zzak zzak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcomorain @codecov-io @zzak