Skip to content

Commit

Permalink
Merge pull request #140 from CircleCI-Public/consistent-promote-inc
Browse files Browse the repository at this point in the history
Ensure consistency on output for promote/increment
  • Loading branch information
Zachary Scott authored Sep 29, 2018
2 parents e9c8624 + 8f12065 commit 5629f54
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cmd/orb.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ func incrementOrb(cmd *cobra.Command, args []string) error {
return err
}

Logger.Infof("Orb `%s` bumped to '%s'.\n", ref, response.HighestVersion)
Logger.Infof("Orb `%s/%s@%s` was published.\n", namespace, orb, response.HighestVersion)
Logger.Info("Please note that this is an open orb and is world-readable.")
return nil
}
Expand All @@ -287,7 +287,7 @@ func promoteOrb(cmd *cobra.Command, args []string) error {
return err
}

Logger.Infof("Orb `%s` promoted to '%s'.\n", ref, response.HighestVersion)
Logger.Infof("Orb `%s/%s@%s` was published.\n", namespace, orb, response.HighestVersion)
Logger.Info("Please note that this is an open orb and is world-readable.")
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/orb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ var _ = Describe("Orb integration tests", func() {
session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)

Expect(err).ShouldNot(HaveOccurred())
Eventually(session.Out).Should(gbytes.Say("Orb `my/orb` bumped to '0.1.0'."))
Eventually(session.Out).Should(gbytes.Say("Orb `my/orb@0.1.0` was published."))
Eventually(session.Out).Should(gbytes.Say("Please note that this is an open orb and is world-readable."))
Eventually(session).Should(gexec.Exit(0))
})
Expand Down Expand Up @@ -826,7 +826,7 @@ var _ = Describe("Orb integration tests", func() {
session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)

Expect(err).ShouldNot(HaveOccurred())
Eventually(session.Out).Should(gbytes.Say("Orb `my/orb@dev:foo` promoted to '0.1.0'."))
Eventually(session.Out).Should(gbytes.Say("Orb `my/[email protected]` was published."))
Eventually(session.Out).Should(gbytes.Say("Please note that this is an open orb and is world-readable."))
Eventually(session).Should(gexec.Exit(0))
})
Expand Down

0 comments on commit 5629f54

Please sign in to comment.