Handle circleci command being missing in chrome install #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows usage of the Chrome install script in Dockerfiles where circleci is not installed. Note that none of the other install scripts reply on circleci. This was working until this PR last week
Example Dockerfile snippet:
Without this change, line 5:
Fails with
circleci: command not found
and just setsPROCESSED_CHROME_VERSION
to be emptyBefore
After
Checklist
Motivation, issues
Recent PR breaks our entire CircleCI pipeline
Description
PROCESSED_CHROME_VERSION
env var whencircleci
is missing so that theORB_PARAM_CHROME_VERSION
env var is used. Use"latest"
as backup