Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable run_task command to wait until the executions ends #231

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

gonrial
Copy link

@gonrial gonrial commented Dec 10, 2024

Closes #230

@gonrial
Copy link
Author

gonrial commented Dec 10, 2024

@marboledacci comments?

Also I don't know how to trigger CircleCI pipeline to check for issues

@marboledacci
Copy link
Contributor

If you mark it ready for review I can run the tests.
Please sign your commits.

@gonrial gonrial marked this pull request as ready for review December 10, 2024 14:06
@gonrial gonrial requested a review from a team as a code owner December 10, 2024 14:06
@marboledacci
Copy link
Contributor

You added the new parameters to the command, but not to the job.

@gonrial
Copy link
Author

gonrial commented Dec 10, 2024

Parameters added to job

src/jobs/run_task.yml Outdated Show resolved Hide resolved
@marboledacci
Copy link
Contributor

This looks good, I'm gonna approve it but will wait for other PR on this orb to merge and release.
It would also be nice to have a test with a task that actually stops to see the right behavior. If you have something, it would be a good enhancement to the PR, otherwise I will try to come up with something.

@gonrial
Copy link
Author

gonrial commented Dec 12, 2024

Added two failing tasks using the new CircleCI required feature that allows a job to fail.
https://circleci.com/changelog/more-flexible-job-required-capabilities/

@marboledacci
Copy link
Contributor

This is not a good test case because CircleCI will mark any job failure as a failure of the workflow, even if more steps are run after that.

@gonrial
Copy link
Author

gonrial commented Dec 12, 2024

Sorry I tried to add a way to test for failure, but that means workflow failure too.

image

Should I comment the failing jobs pointing to this idea request or it's preferable to have a clean yaml?

@marboledacci
Copy link
Contributor

You can point to the request in a comment so we keep that in mind, but don't let the commented tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable run_task command to wait until the executions ends and return the exit code
2 participants