-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable run_task command to wait until the executions ends #231
base: master
Are you sure you want to change the base?
Conversation
@marboledacci comments? Also I don't know how to trigger CircleCI pipeline to check for issues |
If you mark it ready for review I can run the tests. |
You added the new parameters to the command, but not to the job. |
Parameters added to job |
This looks good, I'm gonna approve it but will wait for other PR on this orb to merge and release. |
Added two failing tasks using the new CircleCI required feature that allows a job to fail. |
This is not a good test case because CircleCI will mark any job failure as a failure of the workflow, even if more steps are run after that. |
Sorry I tried to add a way to test for failure, but that means workflow failure too. Should I comment the failing jobs pointing to this idea request or it's preferable to have a clean yaml? |
You can point to the request in a comment so we keep that in mind, but don't let the commented tests. |
Closes #230