-
Notifications
You must be signed in to change notification settings - Fork 514
modified the login form and background image #7955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,74 +4,298 @@ | |||||
| use ChurchCRM\dto\SystemConfig; | ||||||
| use ChurchCRM\dto\SystemURLs; | ||||||
|
|
||||||
| $sPageTitle = gettext('Login'); | ||||||
| $sPageTitle = 'Login'; | ||||||
|
||||||
| $sPageTitle = 'Login'; | |
| $sPageTitle = gettext('Login'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all css should move from inline CSS to webpack
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS background image uses an absolute path (/Images/...) which will break when ChurchCRM is installed in a subdirectory. Use SystemURLs::getRootPath() (or the provided sRootPath) to build the image URL.
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The login header/subtitle is hard-coded (including a specific church name). This should use ChurchMetaData::getChurchName() and wrap user-facing text in gettext() so it works for different deployments and locales.
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout message is now hard-coded and no longer localized. Please use gettext() (and keep wording consistent with the previous translated message) so this notice is translatable.
| echo '<div class="login-error">Your previous session timed out. Please login again.</div>'; | |
| echo '<div class="login-error">' . gettext('Your previous session timed out. Please login again.') . '</div>'; |
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several user-facing strings in the form (placeholders, button label) are no longer wrapped in gettext(), so they won’t be translated. Please restore gettext() usage for these strings to match other session templates.
Copilot
AI
Feb 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Lost Password and Self Registration links are now shown unconditionally. This ignores the existing SystemConfig flags (bEnableLostPassword / bEnableSelfRegistration) and can expose broken links (404 / “not available”). Please gate these sections behind the same config checks as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this for localization