Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: username url xss #7244

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Security: username url xss #7244

merged 3 commits into from
Feb 3, 2025

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Feb 3, 2025

Description & Issue number it closes

Screenshots (if appropriate)

How to test the changes?

see Reflected XSS the login page through the 'username' parameter..pdf
m modules

and get an alert, after the fix it is just added to the username

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream

@DawoudIO DawoudIO added this to the 5.14.0 milestone Feb 3, 2025
@DawoudIO DawoudIO requested a review from a team as a code owner February 3, 2025 01:30
@DawoudIO DawoudIO requested review from respencer, grayeul, DAcodedBEAT, MrClever and bigtigerku and removed request for a team February 3, 2025 01:30
@DawoudIO DawoudIO merged commit 27372c7 into master Feb 3, 2025
8 checks passed
@DawoudIO DawoudIO deleted the security/username branch February 3, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant