Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rejected character with acceptable one #7047

Merged
merged 1 commit into from
May 27, 2024

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

Replace unacceptable \r with acceptable \n.

Resolves #1432

I've checked, and they have already been replaced in the translated output.

Screenshots (if appropriate)

None

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual run of: npm run locale-gen

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner May 24, 2024 14:04
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 24, 2024 14:04
Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix in po editor so that we keep the translation then I'll download and approve this request

Thanks for finding them

@respencer
Copy link
Contributor Author

Let me fix in po editor so that we keep the translation then I'll download and approve this request

Thanks for finding them

You should find that it has already been changed on POEditor.

@respencer respencer force-pushed the 1432-remove-newlines branch from 2001f6b to 3e29148 Compare May 27, 2024 08:16
@DAcodedBEAT DAcodedBEAT merged commit 49392a6 into ChurchCRM:master May 27, 2024
3 checks passed
@respencer respencer deleted the 1432-remove-newlines branch May 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config_cfg locale warnings
3 participants