Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement of State field #7033

Merged

Conversation

respencer
Copy link
Contributor

@respencer respencer commented May 17, 2024

Description & Issue number it closes

You can't force a requirement on state, as not every address has a State associated with it.

The JavaScript is also partially broken on this page.

Will resolve #7032 if completed.

Screenshots (if appropriate)

See #7032

How to test the changes?

Manually testing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer linked an issue May 17, 2024 that may be closed by this pull request
DawoudIO
DawoudIO previously approved these changes May 17, 2024
@DawoudIO DawoudIO dismissed their stale review May 17, 2024 17:17

Need to add a test

@respencer
Copy link
Contributor Author

@DawoudIO: Can we please skip the test for now. I'm planning a rewrite of the States fields soon.

@respencer respencer requested a review from DawoudIO May 18, 2024 09:30
@respencer respencer force-pushed the 7032-required-state-causes-issue-on-self-registration-page branch from b183165 to bf22827 Compare May 18, 2024 09:30
@respencer respencer marked this pull request as ready for review May 18, 2024 09:31
@respencer respencer requested a review from a team as a code owner May 18, 2024 09:31
@respencer respencer requested review from grayeul, DAcodedBEAT and MrClever and removed request for a team May 18, 2024 09:31
@respencer respencer force-pushed the 7032-required-state-causes-issue-on-self-registration-page branch 2 times, most recently from 9bbf5a6 to 4e90116 Compare May 25, 2024 13:45
Copy link
Contributor

@DAcodedBEAT DAcodedBEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good first step!

@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 26, 2024
@respencer respencer force-pushed the 7032-required-state-causes-issue-on-self-registration-page branch from 4e90116 to 2d81021 Compare May 26, 2024 14:45
@respencer respencer force-pushed the 7032-required-state-causes-issue-on-self-registration-page branch from 2d81021 to 9e8d5b0 Compare May 27, 2024 08:14
@DAcodedBEAT DAcodedBEAT merged commit bd0ee3c into master May 27, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the 7032-required-state-causes-issue-on-self-registration-page branch May 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required State causes issue on Self Registration page
3 participants