Merge pull request #6825 from ChurchCRM/fix-custom-field-number

[custom field] mb_substr($fieldInfo->name, 1) string must be cast to int to do arithmetic
ChurchCRM · Jan 18, 2024 · 0ab2f01 · 0ab2f01
2 parents 29ffcfa + c6da975
commit 0ab2f01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/FamilyCustomFieldsEditor.php b/src/FamilyCustomFieldsEditor.php
@@ -136,7 +136,7 @@
                 // doesn't allow numeric-only field (table column) names.
                 $fields = mysqli_query($cnInfoCentral, 'SELECT * FROM family_custom');
                 $fieldInfo = mysqli_fetch_field_direct($fields, $last);
-                $newFieldNum = mb_substr($fieldInfo->name, 1) + 1;
+                $newFieldNum = (int) mb_substr($fieldInfo->name, 1) + 1;
 
                 // If we're inserting a new custom-list type field,
                 // create a new list and get its ID

diff --git a/src/PersonCustomFieldsEditor.php b/src/PersonCustomFieldsEditor.php
@@ -127,7 +127,7 @@
                     // The "c#" naming scheme is necessary because MySQL 3.23 doesn't allow numeric-only field (table column) names.
                     $fields = mysqli_query($cnInfoCentral, 'SELECT * FROM person_custom');
                     $fieldInfo = mysqli_fetch_field_direct($fields, $last);
-                    $newFieldNum = mb_substr($fieldInfo->name, 1) + 1;
+                    $newFieldNum = (int) mb_substr($fieldInfo->name, 1) + 1;
 
                     // If we're inserting a new custom-list type field, create a new list and get its ID
                     if ($newFieldType == 12) {