Fix range check / buffer overflow in ExpressionHasher.Append(char, char) #8998
+139
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar) (ChilliCream#8811) # Conflicts: # src/GreenDonut/src/GreenDonut.Data/Internal/ExpressionHasher.cs
tobias-tengler
changed the title
tobias-tengler
approved these changes
Dec 12, 2025
Member
tobias-tengler
left a comment
tobias-tengler
left a comment
There was a problem hiding this comment.
Whoops, I didn't see your comment on the original issue... Thanks for taking matters into your own hands! :)
tobias-tengler
merged commit a3c664d
into
ChilliCream:main-version-15
104 of 105 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-version-15 #8998 +/- ##
=======================================
=======================================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8811 to v15