Aligned the OneOf implementation with the specification #8352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Oneof
/oneof
toOneOf
.{ a: null }
.❓ Questions:
How should we handle this change? (see Slack)"The@oneOf
directive must not be provided by an Input Object type extension."How should we handle this? Is this only for "real" extensions? Do we even support that? Does it apply to HC type extensions?VariableVisitor.IsNonNullPosition
based on the spec.Do we need to change something here?Should we "unflag" it (remove config, on by default)? (seems to be the case in JS/Ruby and maybe Java).