Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required s_ prefix for static field names #7958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 27, 2025

Summary of the changes (Less than 80 chars)

  • Required s_ prefix for static field names.

It's a suggestion for now, we can change it to a warning once all existing code has been updated.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (01b22c4) to head (9d8f18c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7958      +/-   ##
==========================================
+ Coverage   74.31%   74.36%   +0.04%     
==========================================
  Files        2882     2882              
  Lines      150702   151035     +333     
  Branches    17533    17567      +34     
==========================================
+ Hits       111998   112317     +319     
- Misses      32878    32888      +10     
- Partials     5826     5830       +4     
Flag Coverage Δ
unittests 74.36% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant