[Fusion] Add failing tests for selections below shared, non-refetchable field #7950
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7950 +/- ##
==========================================
+ Coverage 74.39% 74.41% +0.02%
==========================================
Files 2880 2880
Lines 150378 150432 +54
Branches 17487 17494 +7
==========================================
+ Hits 111871 111947 +76
+ Misses 32691 32670 -21
+ Partials 5816 5815 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tobias-tengler
force-pushed
the
tte/fusion-bug-with-shared-field
branch
6 times, most recently
from
957e630 to
a50be56
Compare
tobias-tengler
changed the title
This reverts commit a50be56.
tobias-tengler
force-pushed
the
tte/fusion-bug-with-shared-field
branch
from
5103ad8 to
818bbc4
Compare
| var typeMetadata = _config.GetType<ObjectTypeMetadata>(path.Selection.DeclaringType.Name); | ||
| var typeMetadata = _config.GetType<ObjectTypeMetadata>(current.Selection.DeclaringType.Name); | ||
|
|
||
| if (!typeMetadata.Fields[path.Selection.Field.Name].Bindings.ContainsSubgraph(subgraphName)) | ||
| if (!typeMetadata.Fields[current.Selection.Field.Name].Bindings.ContainsSubgraph(subgraphName)) |
There was a problem hiding this comment.
This ensures that we fail the query plan generation early instead of either failing later or producing an invalid query plan that fails at runtime.
| sb.Append('/'); | ||
| sb.Append(Selection.ResponseName); | ||
| sb.Insert(0, '/'); | ||
| sb.Insert(1, current.Selection.ResponseName); |
There was a problem hiding this comment.
This is purely for debugging purposes. Previously the ToString would return something like name/brand/productById instead of productById/brand/name which would be more helpful to understand the path.
No description provided.