Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

107 redo lock reservation price #141

Open
wants to merge 30 commits into
base: staging
Choose a base branch
from
Open

107 redo lock reservation price #141

wants to merge 30 commits into from

Commits on Dec 20, 2021

  1. Add price_lock_date field to Reservation. Add variables to the conven… 

    …tion details to enable its use.
    @Lasiorhine
    Lasiorhine committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    53c259d View commit details
    Browse the repository at this point in the history

  2. Add methods to Claim and Membership for use in chosing whether to set… 

    … a price_lock_date in Reservation.
    @Lasiorhine
    Lasiorhine committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    6d93c82 View commit details
    Browse the repository at this point in the history

  3. rough out methods for considering and setting an upgrade price lock i… 

    …n Reservation.
    @Lasiorhine
    Lasiorhine committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    b747bdb View commit details
    Browse the repository at this point in the history

  4. Rough out mechanism for reading and using Reservation's upgrade price… 

    … lock in the upgrades controller, query, and command.
    @Lasiorhine
    Lasiorhine committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    428fcb7 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. remove pry binding from upgrade_offer query.

    @Lasiorhine
    Lasiorhine committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    662a05f View commit details
    Browse the repository at this point in the history

  2. make certain reservation class methods private.

    @Lasiorhine
    Lasiorhine committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7719418 View commit details
    Browse the repository at this point in the history

  3. Most tests for Reservation's new class methods finished and green aft… 

    …er appropriate fails. Remaining tests for same stubbed.
    @Lasiorhine
    Lasiorhine committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a409222 View commit details
    Browse the repository at this point in the history

  4. last of Reservation's new tests mostly roughed out.

    @Lasiorhine
    Lasiorhine committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0c2185e View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. misc reservation spec revision

    @Lasiorhine
    Lasiorhine committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    79e5d9a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'staging' into 107-REDO-lock-reservation-price

    @Lasiorhine
    Lasiorhine committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    c5b0e52 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. merge conflict resolution

    @Lasiorhine
    Lasiorhine committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    4344009 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Revise Claim to avoid breaking nil values.

    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5618254 View commit details
    Browse the repository at this point in the history

  2. automatic structure change following resolution of merge conflict.

    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    22ac0ae View commit details
    Browse the repository at this point in the history

  3. Add price-locking mechanism and corresponding tests to Reservation.

    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    8f9dc0b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'staging' into 107-REDO-lock-reservation-price

    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    895ea45 View commit details
    Browse the repository at this point in the history

  5. change to structure.sql after post-merge conflict migration.

    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ed29a85 View commit details
    Browse the repository at this point in the history

  6. Revisions to upgrade_offer_spec to test changes to upgrade_offer. Rea… 

    …dability and method exposure edits, plus small bugfixes in upgrade_offer.
    @Lasiorhine
    Lasiorhine committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b4ff5cc View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Created a query to find reservations that qualify for backdated price… 

    … lock dates.
    @Lasiorhine
    Lasiorhine committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    36a26a2 View commit details
    Browse the repository at this point in the history

  2. Created a command that will update all reservations that qualify for … 

    …backdated price lock dates.
    @Lasiorhine
    Lasiorhine committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    00c5108 View commit details
    Browse the repository at this point in the history

  3. Within Reservation, made a previously private method public so it cou… 

    …ld be used in testing.
    @Lasiorhine
    Lasiorhine committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    4d68a20 View commit details
    Browse the repository at this point in the history

  4. Readability and output format edits to price_lock_backdater.

    @Lasiorhine
    Lasiorhine committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    b7fa3e9 View commit details
    Browse the repository at this point in the history

  5. Rake tasks to run pricelock backdating data migration.

    @Lasiorhine
    Lasiorhine committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    1f1a77d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Finalized query for pricelock-qualified reservations, as well as its … 

    …spec, after appropriate fails.
    @Lasiorhine
    Lasiorhine committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    7a70183 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Added tests for the price_lock_backdater command, which are all green… 

    … after appropriate fails. Revisions to price_lock_backdater indicated by tests.
    @Lasiorhine
    Lasiorhine committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    8a8da0e View commit details
    Browse the repository at this point in the history

  2. removed unnecessary rake file.

    @Lasiorhine
    Lasiorhine committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    131f416 View commit details
    Browse the repository at this point in the history

  3. Added rake tasks to run the price_lock_backdater.

    @Lasiorhine
    Lasiorhine committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    4f7870e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'staging' into 107-REDO-lock-reservation-price

    @Lasiorhine
    Lasiorhine committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    29c8510 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. added some installment requests to seeded ChicagoContact instances wi… 

    …th claims.
    @Lasiorhine
    Lasiorhine committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    64da898 View commit details
    Browse the repository at this point in the history

  2. Finalized rake task for running the data migration.

    @Lasiorhine
    Lasiorhine committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    41b7e15 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Remove mkmf.log

    @Lasiorhine
    Lasiorhine committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    198b1aa View commit details
    Browse the repository at this point in the history