feat: replace zipfile with zipread in epub #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've submitted it to upstream(julien-c/epub#60), but since the upstream merge might take some time, I'm also submitting it here for your consideration. Another benefit is that after removing zipfile, the total package size on Windows has decreased from 90,876KB to 87,331KB, reducing it by nearly 3MB. |
kangfenmao
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zipfile(https://github.com/mapbox/node-zipfile) package currently fails to compile on Node.js 12 and above across Mac/Windows/Linux platforms, and doesn't support Mac ARM or Windows ARM architectures. When using the epub library, requiring zipfile fails, defaulting to adm-zip instead.
https://github.com/CherryHQ/cherry-studio/actions/runs/13823838151/job/38674953209
https://github.com/CherryHQ/cherry-studio/actions/runs/13823838151/job/38674953218
zipread uses Node.js's built-in zlib library, offering similar performance to zipfile without requiring compilation, and supports Mac ARM/Windows ARM architectures. Please consider replacing the zipfile package with this alternative.
https://github.com/szastupov/zipread
zipread is a ZIP file reader designed for speed and memory efficiency. Unlike other modules, it doesn't read the whole file into memory and uses native ZLIB functions for decompression.