Fixed GoogleJavaFormat using google-java-format-1.15.0 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TVolden
reviewed
Jan 27, 2023
Comment on lines
+120
to
+121
| "Unable to handle request ({}), the active session was not found for" | ||
| + " {}.", |
There was a problem hiding this comment.
Maybe skip the strick line length here, it doesn't really improve readability.
Comment on lines
+56
to
+57
| private final Map< | ||
| String, AbstractMap.SimpleImmutableEntry<String, CompletableFuture<Confirmation>>> |
There was a problem hiding this comment.
Again, the strict line length makes the code less readable.
| @@ -59,20 +59,24 @@ public interface ClientSecurityExtEventHandler { | |||
| DeleteCertificateConfirmation handleDeleteCertificateRequest(DeleteCertificateRequest request); | |||
|
|
|||
| /** | |||
| * Handle a {@link ExtendedTriggerMessageRequest} and return a {@link ExtendedTriggerMessageConfirmation}. | |||
| * Handle a {@link ExtendedTriggerMessageRequest} and return a {@link | |||
|
Sorry I forgot to post my comments. |
|
Hi @TVolden, I am no longer working on this project. I agree with you that some lines are less readable, but they are like the generator leave (google java format). I did these modification because without do that, gradle didn't work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to build the project using gradle, I receive an error with the format of some files, I was fixed the format of those files