Add missing wait in chat_profiles test #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The tests already take a long time, I would prefer if instead of an arbitrary 1s wait you could wait for whatever it is that needs to happen before being able to submit. For example, through an alias to intercept HTTP events: Or using a |
dosubot
bot
added
size:S
|
Updated to wait on the chat-input field to be disabled and enabled again, instead of waiting for 1 second. This seems to work fine locally after testing 10+ times. |
dokterbob
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Yay, instead of 1s extra, one less 1s wait in E2E tests!
Thanks @jfperusse-bhvr!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential failure in the second chat_profiles test as it is not currently waiting after changing the model to GPT-4.
This test was constantly failing for me on the latest main without the added wait.