Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter feedback 0 for nevigate feedback #1368

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhiwehu
Copy link

@zhiwehu zhiwehu commented Sep 22, 2024

if filter the nevigate (value is 0), it'll make feedback value to None then it'll filter all the threads.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 22, 2024
@dokterbob
Copy link
Collaborator

Thanks for the contrib! @qtangs is currently working on a full refactor of the SQLAlchemy stuff, I already asked him to take this into account. It would be good to have unittest for this as well.

@dokterbob
Copy link
Collaborator

@dosu Is there perhaps a more elegant and readable way to implement the same functionality?

Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR; Please, try and add a regression test.

We now have unit tests for SQLAlchemy, based on SQLite.

As such, would you be able to write a regression test, forked off main, which will fail without your patch, such that if you cherry-pick it into your PR, the tests pass? That way we can be 100% sure what the reproduction case is, that your patch will fix it and that it won't come back in the future?

If you do not have experience with unit tests, I recommend Claude to help writing them!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants